[HEADS UP] Removal of DiscoveryPlugin in Aries RSA zookeeper discovery

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[HEADS UP] Removal of DiscoveryPlugin in Aries RSA zookeeper discovery

Christian Schneider
I am currently preparing Aries RSA for the OSGi R7 tck tests.

During this work I am also looking into cleaning up old stuff.
I found that the DiscoveryPlugin facility in the zookeeper discovery does not seem to work at all.
The properties are changed but never used in writing the endpoint to zookeeper. 
So as this was not found until now I doubt anyone is using the DiscoveryPlugin services.

I would like to take the opportunity to remove this extensibility point. 

Please speak up if you need or use this.

Christian 

--
--
Christian Schneider

http://www.liquid-reality.de

Computer Scientist

Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Removal of DiscoveryPlugin in Aries RSA zookeeper discovery

Timothy Ward-2
+1 for removing it. I disagreed with it as a solution in the first place - it is up to the Topology Manager and RemoteServiceAdmin to generate an EndpointDescription. Once it has been generated it should not be “fiddled with” by the discovery layer as this could break a lot of things!

Tim

On 7 Feb 2018, at 10:08, Christian Schneider <[hidden email]> wrote:

I am currently preparing Aries RSA for the OSGi R7 tck tests.

During this work I am also looking into cleaning up old stuff.
I found that the DiscoveryPlugin facility in the zookeeper discovery does not seem to work at all.
The properties are changed but never used in writing the endpoint to zookeeper. 
So as this was not found until now I doubt anyone is using the DiscoveryPlugin services.

I would like to take the opportunity to remove this extensibility point. 

Please speak up if you need or use this.

Christian 

--
--
Christian Schneider

http://www.liquid-reality.de

Computer Scientist


Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Removal of DiscoveryPlugin in Aries RSA zookeeper discovery

David Bosschaert
+1 for removing broken code :)

On 7 February 2018 at 10:38, Timothy Ward <[hidden email]> wrote:
+1 for removing it. I disagreed with it as a solution in the first place - it is up to the Topology Manager and RemoteServiceAdmin to generate an EndpointDescription. Once it has been generated it should not be “fiddled with” by the discovery layer as this could break a lot of things!

Tim


On 7 Feb 2018, at 10:08, Christian Schneider <[hidden email]> wrote:

I am currently preparing Aries RSA for the OSGi R7 tck tests.

During this work I am also looking into cleaning up old stuff.
I found that the DiscoveryPlugin facility in the zookeeper discovery does not seem to work at all.
The properties are changed but never used in writing the endpoint to zookeeper. 
So as this was not found until now I doubt anyone is using the DiscoveryPlugin services.

I would like to take the opportunity to remove this extensibility point. 

Please speak up if you need or use this.

Christian 

--
--
Christian Schneider

http://www.liquid-reality.de

Computer Scientist



Reply | Threaded
Open this post in threaded view
|

Re: [HEADS UP] Removal of DiscoveryPlugin in Aries RSA zookeeper discovery

Jean-Baptiste Onofré
+1 as well

Regards
JB

On 02/07/2018 11:55 AM, David Bosschaert wrote:

> +1 for removing broken code :)
>
> On 7 February 2018 at 10:38, Timothy Ward <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     +1 for removing it. I disagreed with it as a solution in the first place -
>     it is up to the Topology Manager and RemoteServiceAdmin to generate an
>     EndpointDescription. Once it has been generated it should not be “fiddled
>     with” by the discovery layer as this could break a lot of things!
>
>     Tim
>
>
>>     On 7 Feb 2018, at 10:08, Christian Schneider <[hidden email]
>>     <mailto:[hidden email]>> wrote:
>>
>>     I am currently preparing Aries RSA for the OSGi R7 tck tests.
>>
>>     During this work I am also looking into cleaning up old stuff.
>>     I found that the DiscoveryPlugin facility in the zookeeper discovery does
>>     not seem to work at all.
>>     The properties are changed but never used in writing the endpoint to
>>     zookeeper. 
>>     So as this was not found until now I doubt anyone is using the
>>     DiscoveryPlugin services.
>>
>>     I would like to take the opportunity to remove this extensibility point. 
>>
>>     Please speak up if you need or use this.
>>
>>     Christian 
>>
>>     --
>>     --
>>     Christian Schneider
>>     http://www.liquid-reality.de <http://www.liquid-reality.de/>
>>
>>     Computer Scientist
>>     http://www.adobe.com <http://www.adobe.com/>
>>
>
>

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com